mirror of
https://git.vectorsigma.ru/public/photoview.git
synced 2026-08-03 21:09:05 +00:00
1f8664d7f8
I encountered with the following error: > 2023/02/05 07:33:00 /app/scanner/face_detection/face_detector.go:92 sql: transaction has already been committed or rolled back > [0.042ms] [rows:0] SELECT * FROM `media` WHERE `media`.`id` = 823 ORDER BY `media`.`id` LIMIT 1 > 2023/02/05 07:33:00 ERROR: Error detecting faces in image (/photos/Borzsony2017/DSC_0028.NEF): sql: transaction has already been committed or rolled back It turned out it comes from the api/routes/photos.go I found a very similar code in album_scanner.go. The difference I saw was that while in the single photo request the transaction passed to the `scanner_tasks.Tasks.BeforeProcessMedia` call, in the album_scann.go the transaction created after this call and created from the context which returned by `BeforeProcessMedia`. Another difference was that in the `ProcessSingleMedia` call the `AfterProcessMedia` call was called with the same - db transaction - context, in the album_scanner it was called outside of the transaction. I changed the logic by merging the two behavior: Create the transaction from the context of `BeforeProcessMedia` and also use the transaction context in the `AfterProcessMedia`. After the change the error disappeared. So to have it in a common place I extracted that logic into a function and use for both the single photo request and in the album scanner. I did not go more deeper to find out what's going on with the context under the hood.
70 lines
1.9 KiB
Go
70 lines
1.9 KiB
Go
package routes
|
|
|
|
import (
|
|
"log"
|
|
"net/http"
|
|
"os"
|
|
|
|
"github.com/gorilla/mux"
|
|
"gorm.io/gorm"
|
|
|
|
"github.com/photoview/photoview/api/graphql/models"
|
|
"github.com/photoview/photoview/api/scanner"
|
|
)
|
|
|
|
func RegisterPhotoRoutes(db *gorm.DB, router *mux.Router) {
|
|
|
|
router.HandleFunc("/{name}", func(w http.ResponseWriter, r *http.Request) {
|
|
mediaName := mux.Vars(r)["name"]
|
|
|
|
var mediaURL models.MediaURL
|
|
result := db.Model(&models.MediaURL{}).Joins("Media").Select("media_urls.*").Where("media_urls.media_name = ?", mediaName).Scan(&mediaURL)
|
|
if err := result.Error; err != nil {
|
|
w.WriteHeader(http.StatusNotFound)
|
|
w.Write([]byte("404"))
|
|
return
|
|
}
|
|
|
|
media := mediaURL.Media
|
|
|
|
if success, response, status, err := authenticateMedia(media, db, r); !success {
|
|
if err != nil {
|
|
log.Printf("WARN: error authenticating photo: %s\n", err)
|
|
}
|
|
w.WriteHeader(status)
|
|
w.Write([]byte(response))
|
|
return
|
|
}
|
|
|
|
cachedPath, err := mediaURL.CachedPath()
|
|
if err != nil {
|
|
log.Printf("ERROR: %s\n", err)
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
w.Write([]byte("internal server error"))
|
|
return
|
|
}
|
|
|
|
if _, err := os.Stat(cachedPath); os.IsNotExist((err)) {
|
|
// err := db.Transaction(func(tx *gorm.DB) error {
|
|
if err = scanner.ProcessSingleMedia(db, media); err != nil {
|
|
log.Printf("ERROR: processing image not found in cache (%s): %s\n", cachedPath, err)
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
w.Write([]byte("internal server error"))
|
|
return
|
|
}
|
|
|
|
if _, err = os.Stat(cachedPath); err != nil {
|
|
log.Printf("ERROR: after reprocessing image not found in cache (%s): %s\n", cachedPath, err)
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
w.Write([]byte("internal server error"))
|
|
return
|
|
}
|
|
}
|
|
|
|
// Allow caching the resource for 1 day
|
|
w.Header().Set("Cache-Control", "private, max-age=86400, immutable")
|
|
|
|
http.ServeFile(w, r, cachedPath)
|
|
})
|
|
}
|