Remove continue-on-error: true because it hides errors. (#1129)

* Add test for the workflow.

* Remove continue-on-error.

* Remove always failing test.

* Fix the hidden failure.

* Regenerated.

.github/workflows/tests.yml

@@ -66,7 +66,6 @@ jobs:
 
     - name: Test
       id: test
-      continue-on-error: true
       run: |
         docker run --name test --network host \
             -v "${{ github.workspace }}:/app" \
@@ -111,7 +110,6 @@ jobs:
 
     - name: Test
       id: test
-      continue-on-error: true
       run: |
         docker run --name test photoview/ui npm run test:ci
         docker cp test:/app/ui/coverage ./ui/

api/graphql/generated.go

@@ -1665,8 +1665,8 @@ func (e *executableSchema) Complexity(typeName, field string, childComplexity in
 }
 
 func (e *executableSchema) Exec(ctx context.Context) graphql.ResponseHandler {
-	rc := graphql.GetOperationContext(ctx)
-	ec := executionContext{rc, e, 0, 0, make(chan graphql.DeferredResult)}
+	opCtx := graphql.GetOperationContext(ctx)
+	ec := executionContext{opCtx, e, 0, 0, make(chan graphql.DeferredResult)}
 	inputUnmarshalMap := graphql.BuildUnmarshalerMap(
 		ec.unmarshalInputOrdering,
 		ec.unmarshalInputPagination,
@@ -1674,7 +1674,7 @@ func (e *executableSchema) Exec(ctx context.Context) graphql.ResponseHandler {
 	)
 	first := true
 
-	switch rc.Operation.Operation {
+	switch opCtx.Operation.Operation {
 	case ast.Query:
 		return func(ctx context.Context) *graphql.Response {
 			var response graphql.Response
@@ -1682,7 +1682,7 @@ func (e *executableSchema) Exec(ctx context.Context) graphql.ResponseHandler {
 			if first {
 				first = false
 				ctx = graphql.WithUnmarshalerMap(ctx, inputUnmarshalMap)
-				data = ec._Query(ctx, rc.Operation.SelectionSet)
+				data = ec._Query(ctx, opCtx.Operation.SelectionSet)
 			} else {
 				if atomic.LoadInt32(&ec.pendingDeferred) > 0 {
 					result := <-ec.deferredResults
@@ -1712,7 +1712,7 @@ func (e *executableSchema) Exec(ctx context.Context) graphql.ResponseHandler {
 			}
 			first = false
 			ctx = graphql.WithUnmarshalerMap(ctx, inputUnmarshalMap)
-			data := ec._Mutation(ctx, rc.Operation.SelectionSet)
+			data := ec._Mutation(ctx, opCtx.Operation.SelectionSet)
 			var buf bytes.Buffer
 			data.MarshalGQL(&buf)
 
@@ -1721,7 +1721,7 @@ func (e *executableSchema) Exec(ctx context.Context) graphql.ResponseHandler {
 			}
 		}
 	case ast.Subscription:
-		next := ec._Subscription(ctx, rc.Operation.SelectionSet)
+		next := ec._Subscription(ctx, opCtx.Operation.SelectionSet)
 
 		var buf bytes.Buffer
 		return func(ctx context.Context) *graphql.Response {

api/graphql/resolvers/album.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	"context"

api/graphql/resolvers/faces.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	"context"

api/graphql/resolvers/media.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	"context"

api/graphql/resolvers/media_geo_json.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	"context"

api/graphql/resolvers/notification.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	"context"

api/graphql/resolvers/root.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	api "github.com/photoview/photoview/api/graphql"

api/graphql/resolvers/scanner.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	"context"

api/graphql/resolvers/search.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	"context"

api/graphql/resolvers/share_token.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	"context"

api/graphql/resolvers/site_info.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	"context"

api/graphql/resolvers/thumbnails.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	"context"

api/graphql/resolvers/timeline.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	"context"

api/graphql/resolvers/user.go

@@ -2,7 +2,7 @@ package resolvers
 
 // This file will be automatically regenerated based on the schema, any resolver implementations
 // will be copied through when generating and any unknown code will be moved to the end.
-// Code generated by github.com/99designs/gqlgen version v0.17.55
+// Code generated by github.com/99designs/gqlgen version v0.17.56
 
 import (
 	"context"

api/scanner/media_encoding/executable_worker/magick_cli_test.go

@@ -48,7 +48,7 @@ func TestMagickCliFail(t *testing.T) {
 		t.Fatalf(`MagickCli.EncodeJpeg(...) = nil, should be an error.`)
 	}
 
-	if got, want := err.Error(), `^encoding image with ".*/testdata/bin/magick \[convert input -quality 70 output\]" error: .*$`; !regexp.MustCompile(want).MatchString(got) {
+	if got, want := err.Error(), `^encoding image with ".*/testdata/bin/magick \[input -auto-orient -quality 70 output\]" error: .*$`; !regexp.MustCompile(want).MatchString(got) {
 		t.Errorf(`MagickCli.EncodeJpeg(...) = %q, should be matched with reg pattern %q`, got, want)
 	}
 }